pull_requests: 113801732
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
113801732 | MDExOlB1bGxSZXF1ZXN0MTEzODAxNzMy | 191 | closed | 0 | Fixed bug / incomplete implementation of instance_time stamp | 25460553 | Small fix, but an important one. A lot of messages take an instance_sequence or timestamp. it is called timestamp in the client. I fixed the places where this was still being set to 1. If the instance_timestamp does not agree between calls it can cause you to hang in portal space or other bad things. The PhysicsData.Position structure passes 9 (0-8 ) unnamed timestamps. These were in place - two were set to 0 - however, they were out of order. I am not sure of the other 8, but the last one is the instance_timestamp. I verified this with live server pcaps. I have made it so with what we have implemented so far, we are consistent. It will be important that we get this information out to all contributors as we need to set it for all player messages to totalLogins. I also make the character load and save properly update the totalLogins value. | 2017-04-02T01:46:53Z | 2017-04-14T19:37:28Z | 2017-04-03T01:17:28Z | 2017-04-03T01:17:28Z | b52abcdff2f3c9afc8fa918237c319c8a8f2c94d | 0 | 95f35b7e19917c8782f3b92434e77266753d650f | fccfaa57c9f696a0da394bad77ee64492d4b5c9a | CONTRIBUTOR | 79078680 | https://github.com/ACEmulator/ACE/pull/191 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests