id,node_id,number,state,locked,title,user,body,created_at,updated_at,closed_at,merged_at,merge_commit_sha,assignee,milestone,draft,head,base,author_association,auto_merge,repo,url,merged_by 341940447,MDExOlB1bGxSZXF1ZXN0MzQxOTQwNDQ3,2428,closed,0,ThreadSafeRandom Cleanup,10608427,"This fixes the namespace for ThreadSafeRandom, from ACE -> ACE.Common. It also adds better Summary descriptions. The rest of the file changes are simply adding ACE.Common references. This is mainly commenting and namespace preparation for adding a non-thread safe random class, in effort to reduce lock contention.",2019-11-18T02:55:21Z,2019-11-21T13:22:35Z,2019-11-21T13:22:21Z,2019-11-21T13:22:21Z,12c138cb80283061d02db80fc91c0cc9c05e224b,,,0,808b37b247f6e6ab7e1404feae7f2008ecd10801,0c9eb14766dceb90a4c828a056cf3350ef9437ff,MEMBER,,79078680,https://github.com/ACEmulator/ACE/pull/2428, 342014625,MDExOlB1bGxSZXF1ZXN0MzQyMDE0NjI1,2430,closed,0,WorldObject_Weapon / imbue refactoring,8909245,"So this started with digging into an off-by-1 error for Crippling Blow, and then went down the rabbit hole of fixing some issues with Critical Strike, and figuring out more of the details with that, which eventually lead to finding some scaling issues that mostly affect people who aren't at the caps for imbues yet. Along the way, I ended up cleaning up a lot of WorldObject_Weapon, and moving around some of the functions in that file for better organization / readability. The moving around of some function positions in the file unfortunately makes the git diff a bit confusing to read through, but all of the functionality is the same there, just moved around and refactored a bit. Tested the 4 key imbues: Critical Strike, Crippling Blow, Elemental Rend, and Armor Rend, and verified that all of the new functions are working as expected. More details to follow..",2019-11-18T07:54:04Z,2019-11-21T03:41:59Z,2019-11-21T03:41:58Z,2019-11-21T03:41:58Z,c20a580890d614f155826f5d465981baf69b87cf,,,0,1a82876198578558e6bd43f329056d117bf070fd,0c9eb14766dceb90a4c828a056cf3350ef9437ff,COLLABORATOR,,79078680,https://github.com/ACEmulator/ACE/pull/2430, 342080859,MDExOlB1bGxSZXF1ZXN0MzQyMDgwODU5,2431,closed,0,fixing /buff for life spells,8909245,,2019-11-18T10:36:20Z,2019-11-21T03:42:14Z,2019-11-21T03:42:14Z,2019-11-21T03:42:14Z,d54d6ca72ac8edb09a800829f499f85018a680ae,,,0,6ce051ca5a93c270a37f8111cb3bd19298f125b7,0c9eb14766dceb90a4c828a056cf3350ef9437ff,COLLABORATOR,,79078680,https://github.com/ACEmulator/ACE/pull/2431, 342459851,MDExOlB1bGxSZXF1ZXN0MzQyNDU5ODUx,2435,closed,0,adding support for WeaponMissileDefense and WeaponMagicDefense,8909245,,2019-11-19T02:48:54Z,2019-11-21T03:42:27Z,2019-11-21T03:42:27Z,2019-11-21T03:42:26Z,535f66f633caef59b804c1105e4c44844da4a1ed,,,0,10964ebc40bd880d1d06ed64498876956935a0d0,9f0f8d11224c3e2d2e7e8a13a4143f053f141c7c,COLLABORATOR,,79078680,https://github.com/ACEmulator/ACE/pull/2435, 342865206,MDExOlB1bGxSZXF1ZXN0MzQyODY1MjA2,2436,closed,0,fixing a double message bug for archers,8909245,,2019-11-19T20:03:46Z,2019-11-21T03:42:38Z,2019-11-21T03:42:38Z,2019-11-21T03:42:38Z,bd779b3e1c94d4edaa5f6930b508e937253f5f91,,,0,ec0f972a90914d3f57544f8c05f755a9720f3c48,9f0f8d11224c3e2d2e7e8a13a4143f053f141c7c,COLLABORATOR,,79078680,https://github.com/ACEmulator/ACE/pull/2436, 342980107,MDExOlB1bGxSZXF1ZXN0MzQyOTgwMTA3,2437,closed,0,Rare Crystal update,30803300,"Added the following missing rare crystals: ``` Void 43407 2H 41257 DualW 45367 Reck 45368 Sneak 45360 Dirty 45366 Shield 45369 ``` Removed the following rare WCIDs (they are the ones that gave weird icon and wouldn't stack) I confirmed the correct rares (Light Weapons & Missile Weapons) are in rare table. ``` Anadil's 30238 - Light Weapons Tanua's 30236 - Light Weapons Krau Li's 30223 - Light Weapons Hamid's 30244 - Light Weapons Asmolum's 30243 - Missile Weapons ``` Tested on personal server (set rare drop 1:1) to make sure they dropped and were usable.",2019-11-20T02:08:44Z,2019-11-21T03:43:42Z,2019-11-21T03:43:42Z,2019-11-21T03:43:42Z,55a698c56adc04e9c879aa1c4fc451c4b53768e6,,,0,224f647e9c104de91c2c9760ad9bc346e282a9a9,9f0f8d11224c3e2d2e7e8a13a4143f053f141c7c,COLLABORATOR,,79078680,https://github.com/ACEmulator/ACE/pull/2437, 343246190,MDExOlB1bGxSZXF1ZXN0MzQzMjQ2MTkw,2438,closed,0,"reversing exemption checks, adding missing WeenieObject.IsTypes",8909245,This fixes the bug with TA char positions getting bumped around,2019-11-20T09:12:11Z,2019-11-21T03:42:49Z,2019-11-21T03:42:49Z,2019-11-21T03:42:49Z,e857656afa3b4e4ce39e4843581a11c76b89c5da,,,0,09ab8d8ad09665c3134ce093948e2def2305fcf1,453489f548902b45ea52293ea45930d2c57749e7,COLLABORATOR,,79078680,https://github.com/ACEmulator/ACE/pull/2438, 343713149,MDExOlB1bGxSZXF1ZXN0MzQzNzEzMTQ5,2439,closed,0,adding debug logging for failed player transitions,8909245,,2019-11-20T20:53:58Z,2019-11-21T03:43:00Z,2019-11-21T03:43:00Z,2019-11-21T03:43:00Z,3bb98ed99a69fb984428d444da9c42debc79bee1,,,0,0f42eb39971719d5a8f5b442d2f54f31deb6d88b,453489f548902b45ea52293ea45930d2c57749e7,COLLABORATOR,,79078680,https://github.com/ACEmulator/ACE/pull/2439, 343736071,MDExOlB1bGxSZXF1ZXN0MzQzNzM2MDcx,2441,closed,0,do not set PKTimer for bael'zharon battles,8909245,,2019-11-20T21:40:24Z,2019-11-21T03:43:10Z,2019-11-21T03:43:10Z,2019-11-21T03:43:10Z,d7ef865ca04d6768be111da4eaa22153279e50fb,,,0,d00f2348655df4ef0a1c05846c351504d4ef9a13,453489f548902b45ea52293ea45930d2c57749e7,COLLABORATOR,,79078680,https://github.com/ACEmulator/ACE/pull/2441, 343781902,MDExOlB1bGxSZXF1ZXN0MzQzNzgxOTAy,2442,closed,0,removing player.rotate during looting that wasnt in retail,8909245,"When a corpse or a chest is double clicked, the server always performs a MoveTo and waits for it to successfully complete, before showing the container inventory If the player then rotates their character away from the container, but stays within UseRadius range, and then loots an item, they should NOT be doing a 2nd MoveTo / rotate in this case. See retail video: https://youtu.be/JApdqG-oJps?t=155 Thanks to Damage Master for reporting this issue!",2019-11-21T00:06:43Z,2019-11-21T03:43:20Z,2019-11-21T03:43:20Z,2019-11-21T03:43:20Z,6fb43df4466179bd1c028b179ff2671cf51c999d,,,0,6343c56f2da09650af4ba983e5e7521a3c8d31ec,453489f548902b45ea52293ea45930d2c57749e7,COLLABORATOR,,79078680,https://github.com/ACEmulator/ACE/pull/2442, 343791872,MDExOlB1bGxSZXF1ZXN0MzQzNzkxODcy,2443,closed,0,EnchantmentManagerWithCaching Null Exception Fix,10608427,,2019-11-21T00:49:32Z,2019-11-21T01:25:16Z,2019-11-21T01:24:56Z,2019-11-21T01:24:56Z,902f97230ffb85e73d4c7c794b4970bebb4154ee,,,0,57fc349e8cd3f6cafc0af40119513a9e966d9a64,453489f548902b45ea52293ea45930d2c57749e7,MEMBER,,79078680,https://github.com/ACEmulator/ACE/pull/2443, 343831042,MDExOlB1bGxSZXF1ZXN0MzQzODMxMDQy,2444,closed,0,fixing merge error,8909245,,2019-11-21T03:51:24Z,2020-09-13T09:49:15Z,2019-11-21T04:52:09Z,2019-11-21T04:52:09Z,77daf5cdb620f6f82c62c918930b233cf10e6d47,,,0,1c5a55b34bf836ae734d6ce21f40c7e81e0f5326,55a698c56adc04e9c879aa1c4fc451c4b53768e6,COLLABORATOR,,79078680,https://github.com/ACEmulator/ACE/pull/2444, 343842440,MDExOlB1bGxSZXF1ZXN0MzQzODQyNDQw,2445,closed,0,Update ACE.Adapter to support spawn maps,11369233,,2019-11-21T04:49:43Z,2020-01-15T04:49:28Z,2019-11-21T06:01:07Z,2019-11-21T06:01:07Z,cda2ab9aa396f0d1f78783e9087172ff572399da,,,0,4b7beb936b9e0e87965f89b4855367be6c4aa8dd,77daf5cdb620f6f82c62c918930b233cf10e6d47,MEMBER,,79078680,https://github.com/ACEmulator/ACE/pull/2445,