issues: 596947426
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
596947426 | MDExOlB1bGxSZXF1ZXN0NDAxMTUwMjkw | 2896 | Revert "fixing shade=0, from optimshi (#2870)" | 8909245 | closed | 0 | 0 | 2020-04-09T00:50:01Z | 2020-04-11T16:54:46Z | 2020-04-11T16:54:46Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/2896 | This reverts commit 640847bf55f1de011f3d0a44569782f5c88a1895. This patch causes the Pathwarden armor to appear as the wrong color (incorrect black color) I think it might have something to do with null coalescing, ie. maybe the original data format had a way to distinguish between 'no shade' / null shade and shade=0 The current data format appears to be using non-nullables, so I'm not sure how to make this distinction with the current data format Sending a revert for this patch until someone can chime in with the proper solution | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2896/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |