issues: 436649864
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
436649864 | MDExOlB1bGxSZXF1ZXN0MjczMDkzODQz | 1804 | Testing: ShardDbContextWithFinalize Test | 10608427 | closed | 0 | 0 | 2019-04-24T11:45:31Z | 2019-06-19T01:08:57Z | 2019-04-28T17:17:38Z | MEMBER | 0 | ACEmulator/ACE/pulls/1804 | DbContext does not implement a finalizer, so nothing to call Dipose() for us if we fail to do so ourselves (which we are currentlyl...) This is just a test to see if it helps CE memory usage This might actually be good for master, but, on windows server core 2016, i haven't noticed the need to explicitly add the finalizer. Even without it, my objects seem to get cleaned up. Could just be my test environment isn't exaggerating the underlying issue though. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1804/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |