issues: 301553721
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
301553721 | MDU6SXNzdWUzMDE1NTM3MjE= | 663 | Client does not send GameActionLoginComplete after Entering World | 11369233 | closed | 0 | 2 | 2018-03-01T20:47:10Z | 2018-08-17T21:38:15Z | 2018-08-17T21:38:15Z | MEMBER | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [x] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. <!-- Please list the steps to reproduce a bug here --> This does not happen with specifically reproducible steps for me but the sequence is to start the server and then connect with the client and enter world with a character. It will be apparent the issue is occurring if while portalling into the world you do not receive vital stats for Health/Stamina/Mana, other times vitals do send but you do not exit the purple bubble state. ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> The client no longer processes most messages it receives, sends nothing further outbound and network times out after about 2 minutes. ### Desired functionality. <!-- What would like to see implemented? What is the use case? --> After character enters world and exits portal it sends GameActionLoginComplete 100% of the time, ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> I suspect this issue is due to not fully handling the optional headers correctly in NetworkSession or something along those lines. Obviously the client is expecting something in either a certain order or a certain packet sequence is not being returned because the sending of the GameActionLoginComplete message is entirely automated from the client side and seemingly not triggered by a specific incoming event/message | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/663/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | 79078680 | issue |