issues: 291799764
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
291799764 | MDExOlB1bGxSZXF1ZXN0MTY1MjkwMzUw | 602 | UpdateEnchantment/Gem OnUse | 10187880 | closed | 0 | 2 | 2018-01-26T04:52:50Z | 2018-02-03T17:10:40Z | 2018-02-03T17:10:40Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/602 | I used TortoiseGit to create branch/master. I tried it by git commands only, but it kept telling me no such git directory... Checked it multiple times. I hope I am getting close with Git in general. Reworked GameEventMagicUpdateEnchantment. The way it was currently trying to pack spell data was garbling things up and the packet no longer matched a retail packet. Once I rewrote it, it now matches retail and also shows all spells in use in the active spell tab in the top left corner, with time remaining(client side). This will be implemented server side soon. To demonstrate this, I implemented non contract OnUse for gems. You can use Blackmoor's Favor, or the two gems that are available for sale at the gem shop in Holtburg. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/602/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |