id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 534391168,MDU6SXNzdWU1MzQzOTExNjg=,2507,Criticals don't work with Martyr's hecatomb like they did in retail.,49938610,closed,0,8909245,,13,2019-12-07T11:39:22Z,2019-12-14T20:54:33Z,2019-12-14T20:54:33Z,CONTRIBUTOR,,,," ### Bug Report or Feature Request (mark with an `x`) ``` - [X] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. Have 3 wands: plain wand Critical strike wand made with opal Biting strike quest wand (such as Branith's staff) Tested on Coldeve, against target drudges in Yanshi 1. Use Martyr's Hecatomb (VII in this case) repeatedly 2. Count the number of critical strikes made. 3. Observe that (a) normal wands never give critical hits, but should give 5% like retail (b) critical strike don't give > 5% - 50% critical hits (c) biting strike does seem to work 33% critical from Branith's quest wand Please see example below ### The log given by the failure. Here is the summary of the results: refs: https://asheron.fandom.com/wiki/Combat Critical hits should happen at least 5% of the time for magic ------------------------------------------------------------ jason@firestorm MSYS /c/temp $ grep -i hecatomb starter_wand.log | wc -l 37 jason@firestorm MSYS /c/temp $ grep -i hecatomb starter_wand.log | grep -i crit | wc -l 0 Critial hits should happen higher than 5% of the time up to a 50%? based on skill ----------------------------------------------------------------------------------------------- $ grep -i hecatomb critical_strike.log | wc -l 34 jason@firestorm MSYS /c/temp $ grep -i hecatomb critical_strike.log | grep -i critical | wc -l 0 Biting strike is probably working at 8 / 33 = 33% ------------------------------------------------------------------- $ grep -i hecatomb biting_strike.log | wc -l 33 jason@firestorm MSYS /c/temp $ grep -i hecatomb biting_strike.log | grep -i critical | wc -l 8 ### Desired functionality. Work as in retail, with the magic criticals all working the same for each school ### Mention any other details that might be useful. I have the raw logs if interested","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/2507/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,issue 544066522,MDU6SXNzdWU1NDQwNjY1MjI=,2575,Died twice in a row from a single encounter,49938610,closed,0,,,0,2019-12-31T02:17:32Z,2020-08-31T06:30:16Z,2020-08-31T06:30:16Z,CONTRIBUTOR,,,," ### Bug Report or Feature Request (mark with an `x`) ``` - [X] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. 3 Gold Phantos wasps that attacked at once. ### The log given by the failure. Chat log: Blistered by Gold Phyntos Wasp's lightning, you die! You've lost 16,173 Pyreals, your Atlatl, your Diforsa Sollerets, your Ring, and your Great Mana Charge! Your corpse is located at (20.5N, 63.9E). You've lost 8,087 Pyreals, your Ring, your Gauntlets of Marksmanship, your Bracelet, and your Ring! Your corpse is located at (33.5S, 72.7E). ### Desired functionality. In retail sometimes after dying you would end up with a corpse at the lifestone. In this case, one corpse was on the Eastham beach; another the other was at the lifestone. The bad bit here is two deaths, two penalties and two losses of everything. Would like to die only once, and only loose one set of equipment/one vitae. ### Mention any other details that might be useful. Found on the Levistras server. ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/2575/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,issue 767634305,MDExOlB1bGxSZXF1ZXN0NTQwMjgwNDk4,3391,Send current attacker message to client.,49938610,closed,0,,,2,2020-12-15T14:10:23Z,2020-12-19T21:09:32Z,2020-12-19T21:09:32Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/3391,"Send the current attacker message to the client so that the client can use the last attack keyboard shortcut to select the last attacker. Note that these will be sent often when there are multiple attackers. The message should only be sent when the attacker changes","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/3391/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,pull