id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 288465578,MDExOlB1bGxSZXF1ZXN0MTYyODU4OTc2,588,Fellowships,4855786,closed,0,,,0,2018-01-15T02:39:47Z,2018-01-16T07:05:39Z,2018-01-16T07:05:39Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/588,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/588/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,pull 289835052,MDExOlB1bGxSZXF1ZXN0MTYzODY2Njg1,592,Fellowships,4855786,closed,0,,,0,2018-01-19T01:36:33Z,2018-01-20T02:28:17Z,2018-01-20T02:28:17Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/592,"<= 2.5 map coord away = full share 2.5 to 5 = proportional by range so at 5 map coords away = 0%","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/592/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,pull 290720807,MDExOlB1bGxSZXF1ZXN0MTY0NDkxNzU5,596,Player teleporting away no longer leaves ghost of self.,4855786,closed,0,,,0,2018-01-23T06:15:42Z,2018-01-23T10:01:43Z,2018-01-23T10:01:43Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/596,"ActionChain null wrapper added to not crash server if teleporting player disconnects Resolves 231","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/596/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,pull 296066223,MDExOlB1bGxSZXF1ZXN0MTY4MzgxNzQz,631,Fix for issue #453: bad packet types crash server,4855786,closed,0,,,1,2018-02-10T02:40:31Z,2018-02-10T04:55:11Z,2018-02-10T04:55:11Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/631,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/631/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,pull 296161559,MDU6SXNzdWUyOTYxNjE1NTk=,635,Purchasing a new skill throws Primary key violation inserting new skill row,4855786,closed,0,,,3,2018-02-11T05:10:47Z,2018-03-06T20:03:09Z,2018-03-06T20:03:09Z,CONTRIBUTOR,,,," ### Bug Report or Feature Request (mark with an `x`) ``` - [X] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. 1. Create character 2. Grant experience enough to get enough skill points to purchase a new skill 3. Spend skill points on new skill 4. Wait a bit 5. Server throws exception ### The log given by the failure. {MySql.Data.MySqlClient.MySqlException (0x80004005): Duplicate entry '1342177282-23' for key 'PRIMARY' at MySql.Data.MySqlClient.MySqlStream.ReadPacket() at MySql.Data.MySqlClient.NativeDriver.GetResult(Int32& affectedRow, Int64& insertedId) at MySql.Data.MySqlClient.Driver.NextResult(Int32 statementId, Boolean force) at MySql.Data.MySqlClient.MySqlDataReader.NextResult() at MySql.Data.MySqlClient.MySqlCommand.ExecuteReader(CommandBehavior behavior) at MySql.Data.MySqlClient.MySqlCommand.ExecuteNonQuery() at ACE.Database.Database.DatabaseTransaction.<>c__DisplayClass10_0.b__0() in D:\Repos\spazmodica\ACE\Source\ACE.Database\Database.cs:line 200 at System.Threading.Tasks.Task`1.InnerInvoke() at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)} MySql.Data.MySqlClient.MySqlException ### Desired functionality. Purchasing new skill should not throw error. ### Mention any other details that might be useful. Exception is in Task so does not crash server Inserts vs Updates are determined by the IsDirty and HasEverBeenSavedToDatabase flags Skills are all added to db upon creation, but purchasing does not set above flags correctly triggering error ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/635/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,issue 308376844,MDExOlB1bGxSZXF1ZXN0MTc3MzA1OTk3,702,Item decay,4855786,closed,0,,,1,2018-03-25T19:16:53Z,2018-03-26T18:10:57Z,2018-03-26T18:10:57Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/702,Items dropped on ground will now decay in 2.5 minutes.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/702/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,pull