issue_comments
Data license: AGPL · Data source: ACEmulator Project
13 rows where "updated_at" is on date 2019-01-22
This data as json, CSV (advanced)
Suggested facets: issue_url, user, author_association, issue, created_at (date), updated_at (date)
id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
456231577 | https://github.com/ACEmulator/ACE/issues/1244#issuecomment-456231577 | https://api.github.com/repos/ACEmulator/ACE/issues/1244 | MDEyOklzc3VlQ29tbWVudDQ1NjIzMTU3Nw== | dgatewood 10187880 | 2019-01-22T00:26:09Z | 2019-01-22T00:26:09Z | COLLABORATOR | PR 1338 resolves this | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Quest items appearing in loot 396309390 | |
456261291 | https://github.com/ACEmulator/ACE/pull/1204#issuecomment-456261291 | https://api.github.com/repos/ACEmulator/ACE/issues/1204 | MDEyOklzc3VlQ29tbWVudDQ1NjI2MTI5MQ== | esoterick 70647 | 2019-01-22T03:41:55Z | 2019-01-22T03:41:55Z | NONE | Couple of concerns... Generally speaking API's are meant to be utilized by machines not users. Therefor Basic Authentication isn't usually the best form of Auth for them. Not to mention Basic Auth provides no Authorization components. So if you plan on adding multiple administrative components directly to the server I would recommend also adding a proper RBAC and some sort of API token. The following concerns me 6. Target server downloads packaged snapshot from source server. 7. Source server permanently deletes character upon package download completion. 8. Target server performs cryptographic verification of the snapshot, and rejects it if it's been forged. 9. Target server adds the character to the requester's account. If there is any issue in steps 7 and 8 the user is out of luck. The origin server deleted the origin char and the destination server failed to extract the snapshot of the user's migration. I feel like before anything is deleted both sites are checked for consistency. Once verified drop origin, and toggle/enabled destination. It also seems like there are numerous requests made to both servers for the migration. It seems like there shouldn't need to be. If trust is established between the two servers, the client should only have to make one a single request origin or destination it doesn't matter. The servers can then communicate across their own common api and handle the workflow themselfs. It would also be helpful prior to merging in to the master branch to have this PR squashed to one commit. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Character migrate/backup/import and Web API 394923138 | |
456265523 | https://github.com/ACEmulator/ACE/issues/1343#issuecomment-456265523 | https://api.github.com/repos/ACEmulator/ACE/issues/1343 | MDEyOklzc3VlQ29tbWVudDQ1NjI2NTUyMw== | gmriggs 8909245 | 2019-01-22T04:13:34Z | 2019-01-22T04:13:34Z | COLLABORATOR | These are separate spells, Summon Primary Portal I, II, and III Whether or not all of these should be included in /addallspells is another question.. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Summon Primary Portal I is listed twice in spells book 401592329 | |
456266341 | https://github.com/ACEmulator/ACE/issues/1343#issuecomment-456266341 | https://api.github.com/repos/ACEmulator/ACE/issues/1343 | MDEyOklzc3VlQ29tbWVudDQ1NjI2NjM0MQ== | gmriggs 8909245 | 2019-01-22T04:19:58Z | 2019-01-22T04:27:15Z | COLLABORATOR | oh i see Summon Portal I is actually listed twice in addition to this these are 2 separate spells (157 & 2709), looking into the difference between them... | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Summon Primary Portal I is listed twice in spells book 401592329 | |
456266942 | https://github.com/ACEmulator/ACE/pull/1204#issuecomment-456266942 | https://api.github.com/repos/ACEmulator/ACE/issues/1204 | MDEyOklzc3VlQ29tbWVudDQ1NjI2Njk0Mg== | fartwhif 3317737 | 2019-01-22T04:24:27Z | 2019-01-22T14:26:55Z | COLLABORATOR | > Couple of concerns... > > Generally speaking API's are meant to be utilized by machines not users. Therefor Basic Authentication isn't usually the best form of Auth for them. Not to mention Basic Auth provides no Authorization components. So if you plan on adding multiple administrative components directly to the server I would recommend also adding a proper RBAC and some sort of API token. > > The following concerns me > 6. Target server downloads packaged snapshot from source server. > 7. Source server permanently deletes character upon package download completion. > 8. Target server performs cryptographic verification of the snapshot, and rejects it if it's been forged. > 9. Target server adds the character to the requester's account. > > If there is any issue in steps 7 and 8 the user is out of luck. The origin server deleted the origin char and the destination server failed to extract the snapshot of the user's migration. I feel like before anything is deleted both sites are checked for consistency. Once verified drop origin, and toggle/enabled destination. > > It also seems like there are numerous requests made to both servers for the migration. It seems like there shouldn't need to be. If trust is established between the two servers, the client should only have to make one a single request origin or destination it doesn't matter. The servers can then communicate across their own common api and handle the workflow themselfs. > > It would also be helpful prior to merging in to the master branch to have this PR squashed to one commit. Thanks very much for the review! Token auth was what I had originally planned because it allows for a delay in the authentication step, but it was brought up that it would require the tools using the API to manage sessions. As far as RBAC goes, the current pseudo role/claims based auth is "good enough" in that certain resources require the user to have a certain access level, which is essentially the role, no need to over-complicate things, I've no e… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Character migrate/backup/import and Web API 394923138 | |
456268488 | https://github.com/ACEmulator/ACE/issues/1339#issuecomment-456268488 | https://api.github.com/repos/ACEmulator/ACE/issues/1339 | MDEyOklzc3VlQ29tbWVudDQ1NjI2ODQ4OA== | gmriggs 8909245 | 2019-01-22T04:36:11Z | 2019-01-22T04:36:21Z | COLLABORATOR | They are restoring mana, but it looks like they might not be sending a text message to the player | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Mana Pools Don't Restore Mana 401561450 | |
456270244 | https://github.com/ACEmulator/ACE/issues/1344#issuecomment-456270244 | https://api.github.com/repos/ACEmulator/ACE/issues/1344 | MDEyOklzc3VlQ29tbWVudDQ1NjI3MDI0NA== | gmriggs 8909245 | 2019-01-22T04:49:25Z | 2019-01-22T04:49:25Z | COLLABORATOR | This would be a PY16 data issue... to bring this up-to-date with end of retail, this would probably be a bug for https://github.com/ACEmulator/ACE-World-16PY-Patches/issues | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Ayan Baqur Black Spawn Den Unsummonable 401597785 | |
456271181 | https://github.com/ACEmulator/ACE/issues/1241#issuecomment-456271181 | https://api.github.com/repos/ACEmulator/ACE/issues/1241 | MDEyOklzc3VlQ29tbWVudDQ1NjI3MTE4MQ== | cyberkiller6 37782527 | 2019-01-22T04:56:17Z | 2019-01-22T04:56:17Z | NONE | Can confirm, https://imgur.com/a/BTxmmbU | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Loot item that is magical, but spell-less 396285156 | |
456271428 | https://github.com/ACEmulator/ACE/issues/1344#issuecomment-456271428 | https://api.github.com/repos/ACEmulator/ACE/issues/1344 | MDEyOklzc3VlQ29tbWVudDQ1NjI3MTQyOA== | cyberkiller6 37782527 | 2019-01-22T04:58:08Z | 2019-01-22T04:58:08Z | NONE | Posted issue on PY16 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Ayan Baqur Black Spawn Den Unsummonable 401597785 | |
456353367 | https://github.com/ACEmulator/ACE/issues/1343#issuecomment-456353367 | https://api.github.com/repos/ACEmulator/ACE/issues/1343 | MDEyOklzc3VlQ29tbWVudDQ1NjM1MzM2Nw== | gmriggs 8909245 | 2019-01-22T10:42:01Z | 2019-01-22T10:42:01Z | COLLABORATOR | Fixed in https://github.com/ACEmulator/ACE/pull/1345 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Summon Primary Portal I is listed twice in spells book 401592329 | |
456476352 | https://github.com/ACEmulator/ACE/issues/1282#issuecomment-456476352 | https://api.github.com/repos/ACEmulator/ACE/issues/1282 | MDEyOklzc3VlQ29tbWVudDQ1NjQ3NjM1Mg== | gmriggs 8909245 | 2019-01-22T16:57:49Z | 2019-01-22T16:58:05Z | COLLABORATOR | Added in https://github.com/ACEmulator/ACE/pull/1334 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Movement check on spellcasting 399521078 | |
456476689 | https://github.com/ACEmulator/ACE/issues/1311#issuecomment-456476689 | https://api.github.com/repos/ACEmulator/ACE/issues/1311 | MDEyOklzc3VlQ29tbWVudDQ1NjQ3NjY4OQ== | gmriggs 8909245 | 2019-01-22T16:58:39Z | 2019-01-22T16:58:39Z | COLLABORATOR | Added in https://github.com/ACEmulator/ACE/pull/1335 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fall damage does not work 400557180 | |
456476998 | https://github.com/ACEmulator/ACE/issues/1337#issuecomment-456476998 | https://api.github.com/repos/ACEmulator/ACE/issues/1337 | MDEyOklzc3VlQ29tbWVudDQ1NjQ3Njk5OA== | gmriggs 8909245 | 2019-01-22T16:59:25Z | 2019-01-22T16:59:25Z | COLLABORATOR | Added in https://github.com/ACEmulator/ACE/pull/1346 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Player cannot write in blank parchment/book/tome 401506865 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);