issue_comments
Data license: AGPL · Data source: ACEmulator Project
3 rows where issue = 568749860
This data as json, CSV (advanced)
Suggested facets: user, author_association, created_at (date), updated_at (date)
id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
589524344 | https://github.com/ACEmulator/ACE/pull/2728#issuecomment-589524344 | https://api.github.com/repos/ACEmulator/ACE/issues/2728 | MDEyOklzc3VlQ29tbWVudDU4OTUyNDM0NA== | DridsGhost 58707922 | 2020-02-21T06:55:28Z | 2020-02-21T06:55:28Z | CONTRIBUTOR | Tested around 8 or 9 times. Seems to work without fail. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | fix acclient skipping over ethereal animation hooks for known doors that are opened > 96 distance 568749860 | |
589732745 | https://github.com/ACEmulator/ACE/pull/2728#issuecomment-589732745 | https://api.github.com/repos/ACEmulator/ACE/issues/2728 | MDEyOklzc3VlQ29tbWVudDU4OTczMjc0NQ== | gmriggs 8909245 | 2020-02-21T16:38:47Z | 2020-02-21T16:38:47Z | COLLABORATOR | For a good example between the 1st and 2nd version of this patch: In first version of patch: - start running constantly into a door - open door while running into it expected: to match up with acclient, the doors to the buildings in yaraq for example, have a ~0.3s delay before they turn ethereal actual: the player previously started to run through the doors immediately, in the first version of this patch. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | fix acclient skipping over ethereal animation hooks for known doors that are opened > 96 distance 568749860 | |
589741112 | https://github.com/ACEmulator/ACE/pull/2728#issuecomment-589741112 | https://api.github.com/repos/ACEmulator/ACE/issues/2728 | MDEyOklzc3VlQ29tbWVudDU4OTc0MTExMg== | gmriggs 8909245 | 2020-02-21T16:58:21Z | 2020-02-21T16:58:21Z | COLLABORATOR | nevermind, i misinterpreted the data. the yaraq door is not 0.3s, it is 0.03s -- the hook to change ethereal state is on the second frame of the animation. so ethereal is set to false 1/30 of a second after opening the door, and it is set to true 29/30 of a second after closing the door in other words, at least for the doors i am testing, the original logic was "close enough", and this would be overcomplicating things, unless there are truly any doors where the ethereal hook happens 1/2 way through the animation. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | fix acclient skipping over ethereal animation hooks for known doors that are opened > 96 distance 568749860 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);