issue_comments: 565761123
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/issues/1500#issuecomment-565761123 | https://api.github.com/repos/ACEmulator/ACE/issues/1500 | 565761123 | MDEyOklzc3VlQ29tbWVudDU2NTc2MTEyMw== | 8909245 | 2019-12-14T23:09:10Z | 2019-12-14T23:10:15Z | COLLABORATOR | Just to clarify, this was addressed in https://github.com/ACEmulator/ACE/pull/2491 We actually found from retail pcaps, that this was an issue in retail too. Most of the items in retail *did* have 0 ManaConversionMod in the data, and it was sent during appraisal. The data for these items is actually very inconsistent. In the base 16PY weenies, many of them have 0 ManaConversionMod, and many have it omitted. So this is (unfortunately) working as per retail spec by default. A new server option has been added, /modifybool show_mana_conv_bonus_0 false, which will normalize the appraisal display for these items. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 418551755 |