issue_comments: 565639236
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565639236 | https://api.github.com/repos/ACEmulator/ACE/issues/2507 | 565639236 | MDEyOklzc3VlQ29tbWVudDU2NTYzOTIzNg== | 8909245 | 2019-12-13T22:53:27Z | 2019-12-13T22:53:36Z | COLLABORATOR | One issue that is most likely the cause of CS not working for life magic projectiles is in WorldObject_Weapon.GetImbuedSkillType(): ``` case Skill.WarMagic: case Skill.VoidMagic: return ImbuedSkillType.Magic; default: log.Debug($"WorldObject_Weapon.GetImbuedSkillType({skill?.Skill}): unexpected skill"); return ImbuedSkillType.Undef; ``` This needs to have Skill.LifeMagic added It seems like Biting Strike should already be working, which could be confirmed locally by setting PropertyFloat.CriticalFrequency on the wand to something like 0.5 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 534391168 |