issue_comments: 317275578
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/pull/474#issuecomment-317275578 | https://api.github.com/repos/ACEmulator/ACE/issues/474 | 317275578 | MDEyOklzc3VlQ29tbWVudDMxNzI3NTU3OA== | 25460553 | 2017-07-23T19:19:07Z | 2017-07-23T19:19:07Z | CONTRIBUTOR | I agree that flag can change - pk to non pk is a perfect example. The only thing I was saying is (and I am sure this is just a data saving measure) with all the other flags, you set it and that tells the client, hey - I am sending this down to you in this message. With bool flags like ObjectDescriptionFlag the flag itself is the data. The flag is sent, but no bools are actually sent to the client in the packet only the flag. If I set Attackable - I do not also send a true down to the client. We can either just make methods like you have to behind the scenes manipulate the flag and just update that one field or we can break each flag out as a bool as you are doing, store and update those, then build the flag from that data. It is really 6 of 1 1/2 dozen of the other. It was just something that tripped me up early on the bool flags are the data - I was looking for actual data in the packet stream and it is not sent. Just wanted to make sure we were all on the same page. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 244889108 |