html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565606073,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565606073,MDEyOklzc3VlQ29tbWVudDU2NTYwNjA3Mw==,49938610,2019-12-13T20:57:37Z,2019-12-13T20:57:37Z,CONTRIBUTOR,"I have tested this on a local test server with life magic at 1033 and a Critical strike wand. Crits were low at about 2%
Branith's staff crits about 33% of the time which is an easily noticeable difference.
I can supply logs if interested, or can look into the reason if someone can hint me if it is a code or sql data issue.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565625521,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565625521,MDEyOklzc3VlQ29tbWVudDU2NTYyNTUyMQ==,8909245,2019-12-13T22:04:13Z,2019-12-13T22:04:13Z,COLLABORATOR,"Clearing out this conversation history, because there is a lot of misinformation in here","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565626242,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565626242,MDEyOklzc3VlQ29tbWVudDU2NTYyNjI0Mg==,8909245,2019-12-13T22:06:40Z,2019-12-13T22:07:04Z,COLLABORATOR,"@jspashett can you provide any examples from retail of Martyr's Hecatomb critting? Any lines from the retail pcaps, or any videos from retail would be fine","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565629329,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565629329,MDEyOklzc3VlQ29tbWVudDU2NTYyOTMyOQ==,49938610,2019-12-13T22:17:06Z,2019-12-13T22:17:06Z,CONTRIBUTOR,"Well, I probably can't provide retail evidence just now, However seems like the debate is currently whether my tests are valid.
The chance of having only 5% crits for a CS weapon that should do about 40% over 52 casts is infinity small (and I've posed this twice now)
52 coin tosses all landing the same (at 50% probability) is as follows:
0.5 ^ 52 = 2.2204460492503130808472633361816e-16
^ = power
That would be 0.00000000000000002204 or so %
I hope this illustrates my point. My results may not be totally accurate, but they are improbable if you say this is working.
I can go and try and find some turbine documentations on this if desired. I am currently looking at the code to see why this may happen. it seems clear was does a different thing than life magic does, every single time, by a huge margin.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565630518,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565630518,MDEyOklzc3VlQ29tbWVudDU2NTYzMDUxOA==,8909245,2019-12-13T22:21:04Z,2019-12-13T22:21:04Z,COLLABORATOR,"Ad-hoc testing of this on ACE is currently unneeded. The code is open source and everything about how it currently works is available to anyone.
There is currently no code for life projectiles to crit, because there have been no examples provided yet of a life projectile critting in retail.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565631449,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565631449,MDEyOklzc3VlQ29tbWVudDU2NTYzMTQ0OQ==,49938610,2019-12-13T22:24:07Z,2019-12-13T22:24:07Z,CONTRIBUTOR,"@gmriggs Life magic projectiles do crit though on ACE right now, it's just that the CS property doesn't work. If the question is whether they should or not, then I can go away and try and find that information. I did play a Martyr mage for several years using a CS wand, so I know they used to crit the same as war, but I'll try and find some authoritative information on the subject.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565632953,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565632953,MDEyOklzc3VlQ29tbWVudDU2NTYzMjk1Mw==,8909245,2019-12-13T22:28:58Z,2019-12-13T22:28:58Z,COLLABORATOR,"Ok you are indeed correct about that -- the relevant code is in SpellProjectile.cs on line 397:
```
// could life magic projectiles crit?
// if so, did they use the same 1.5x formula as war magic, instead of 2.0x?
if (criticalHit)
damageBonus = lifeMagicDamage * 0.5f * GetWeaponCritDamageMod(sourceCreature, attackSkill, target);
```
And the part before that, which should be working the same for all spell projectiles (life / war / void bolts):
```
// critical hit
var critical = GetWeaponMagicCritFrequency(sourceCreature, attackSkill, target);
if (ThreadSafeRandom.Next(0.0f, 1.0f) < critical)
{
if (targetPlayer != null && targetPlayer.AugmentationCriticalDefense > 0)
{
var criticalDefenseMod = sourcePlayer != null ? 0.05f : 0.25f;
var criticalDefenseChance = targetPlayer.AugmentationCriticalDefense * criticalDefenseMod;
if (criticalDefenseChance > ThreadSafeRandom.Next(0.0f, 1.0f))
critDefended = true;
}
if (!critDefended)
criticalHit = true;
}
```
I can look into why any existing code is currently not functioning to the intention of how its currently written","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565637118,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565637118,MDEyOklzc3VlQ29tbWVudDU2NTYzNzExOA==,49938610,2019-12-13T22:44:37Z,2019-12-13T22:44:37Z,CONTRIBUTOR,"Hmm. Ok. Sometimes they do say Crit as you've seen from my greps. I have been looking for some information on crits, which is hard to come by nowdays.
Note also, that Biting Stike (not critical strike) does give sensible outputs in the log window.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565639236,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565639236,MDEyOklzc3VlQ29tbWVudDU2NTYzOTIzNg==,8909245,2019-12-13T22:53:27Z,2019-12-13T22:53:36Z,COLLABORATOR,"One issue that is most likely the cause of CS not working for life magic projectiles is in WorldObject_Weapon.GetImbuedSkillType():
```
case Skill.WarMagic:
case Skill.VoidMagic:
return ImbuedSkillType.Magic;
default:
log.Debug($""WorldObject_Weapon.GetImbuedSkillType({skill?.Skill}): unexpected skill"");
return ImbuedSkillType.Undef;
```
This needs to have Skill.LifeMagic added
It seems like Biting Strike should already be working, which could be confirmed locally by setting PropertyFloat.CriticalFrequency on the wand to something like 0.5
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565642387,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565642387,MDEyOklzc3VlQ29tbWVudDU2NTY0MjM4Nw==,8909245,2019-12-13T23:02:52Z,2019-12-13T23:15:49Z,COLLABORATOR,"Also, just to clear up some minor misconceptions that have been floating around in this discussion:
http://acpedia.org/wiki/Announcements_-_2004/07_-_Treaties_in_Stone#Letter_to_the_Players
```Critical Strike for War Magic currently scales from 5% critical hit chance to 25% critical hit chance at maximum effectiveness. In July, the maximum effectiveness will be increased to 50% chance (PvE only).```
This line in the Turbine update notes has mislead a lot of players. It makes it sound like the base crit chance for magic (ie. a wand that doesn't have CS) is 5%, but it is not, it has always been 2%.
http://acpedia.org/wiki/Announcements_-_2002/08_-_Atonement#Letter_to_the_Players
```
// Original:
// http://acpedia.org/wiki/Announcements_-_2002/08_-_Atonement#Letter_to_the_Players
// Critical Strikes: In addition to the skill-based damage bonus, each projectile spell has a 2% chance of causing a critical hit on the target and doing increased damage.
// A magical critical hit is similar in some respects to melee critical hits (although the damage calculation is handled differently).
// While a melee critical hit automatically does twice the maximum damage of the weapon, a magical critical hit will do an additional half the minimum damage of the spell.
// For instance, a magical critical hit from a level 7 spell, which does 110-180 points of damage, would add an additional 55 points of damage to the spell.
// Later updated for PvE only:
// http://acpedia.org/wiki/Announcements_-_2004/07_-_Treaties_in_Stone#Letter_to_the_Players
// Currently when a War Magic spell scores a critical hit, it adds a multiple of the base damage of the spell to a normal damage roll.
// Starting in July, War Magic critical hits will instead add a multiple of the maximum damage of the spell.
// No more crits that do less damage than non-crits!
if (isPVP) // PvP: 50% of the MIN damage added to normal damage roll
damageBonus = Spell.MinDamage * 0.5f;
else // PvE: 50% of the MAX damage added to normal damage roll
damageBonus = Spell.MaxDamage * 0.5f;
```
This ""CS magic starts at 5%"" actually comes from the way all Imbue formulas are written. Even more technical, it comes from the way Melee (base 400) and Missile/Magic (base 360) are tied together, some oddities *only* with Missile/Magic CS and none of the other imbues, and the way Turbine changed this formula in the July 2004 update to give a boost for PvE only.
If you have a War Magic skill of 10, and you equip a CS wand, you don't automatically get boosted from 2% to 5% crit chance. For all imbues, you need to reach a minimum skill level threshold before the imbue starts to become effective.
I could go into more detail about this, but a lot of these specifics about CS magic / 5% when it starts to become effective is explained in the code:
```
// http://acpedia.org/wiki/Announcements_-_2004/07_-_Treaties_in_Stone#Letter_to_the_Players
// For PvE only:
// Critical Strike for War Magic currently scales from 5% critical hit chance to 25% critical hit chance at maximum effectiveness.
// In July, the maximum effectiveness will be increased to 50% chance.
if (skillType == ImbuedSkillType.Magic && isPvP)
baseMod *= 0.5f;
// In the original formula for CS Magic pre-July 2004, (BS - 60) / 1200.0f, the minimum 5% crit rate would have been achieved at BS 120,
// which is exactly equal to the minimum base skill for CS Missile becoming effective.
// CS Magic is slightly different from all the other skill/imbue combinations, in that the MinCriticalStrikeMagicMod
// is different from the defaultMagicCritFrequency (5% vs. 2%)
// If we simply clamp to min. 5% here, then a player will be getting a +3% bonus from from base skill 0-90 in PvE,
// and base skill 0-120 in PvP
// This code is checking if the player has reached the skill threshold for receiving the 5% bonus
```
So basically, in PvE, until you reach base magic skill 90 (or base skill 120 in PvP), the imbue has not reached the minimum threshold to become effective yet. At base magic skill 89 in PvE, your crit chance will be still only be 2% with a CS wand, as the skill cutoff is BS 90 which is exactly where 5% starts.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565644984,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565644984,MDEyOklzc3VlQ29tbWVudDU2NTY0NDk4NA==,49938610,2019-12-13T23:13:14Z,2019-12-13T23:13:14Z,CONTRIBUTOR,"Yes, it's complicated. I remember there being complications... Where does this leave life magic and CS then at this juncture? Right now, quest wands with biting strike do give about 33% crits on life magic, so either that's a bug, or it's correct. CS wands don't seem to do anything much for life magic. I might try asking srand about it, but I don't know if I will get an answer. I do remember reading a turbine forum post where someone asked this, and I remember testing it on retail soon after, but I can't find this on the way back machine, so... well...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168
https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565645400,https://api.github.com/repos/ACEmulator/ACE/issues/2507,565645400,MDEyOklzc3VlQ29tbWVudDU2NTY0NTQwMA==,8909245,2019-12-13T23:14:58Z,2019-12-13T23:14:58Z,COLLABORATOR,"I will fix this up. I think the only bug you are seeing is with CS and Life Projectiles, which the fix is posted in https://github.com/ACEmulator/ACE/issues/2507#issuecomment-565639236 for.
I will be testing all of these scenarios (including Life Projectiles + Bitiing Strike) to make sure this is all working properly","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,534391168